Improving colors for color blind people (issue lichess-org/lila#10410) #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making higher contrast in color brushes so colorblind people can at least see different shades of red and green, and deuteronopia people (blue-green) now should see different shades too, because of making contrast of green and blue higher.
|
Could you post a screenshot of how it looks? Also, you can link to an issue from another repo using lichess-org/lila#10410 And ideally, the PR title should still independently explain what your doing (not just "fix issue 13234") and same goes for the commit title ("update state.ts"). |
|
I added a normal vision representation and a protanopia (red-green colorblindesss) filter simulation of the analysis board. Maybe it should be mentioned that the colours were chosen by color replacing. |
Rabergsel
changed the title
|
After about one year.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue lichess-org/lila#10410 : Colorblind people cant see the difference between red and green.
Making higher contrast in color brushes so colorblind people can at least see different shades of red and green, and
deuteronopia people (blue-green) now should see different shades too, because of making contrast of green and blue higher.
I didn't change the colors in total, I only varied them to make the contrast higher (and for me they still look good).